-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Make Components.get ignore components with confidence = 0 #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Components.get ignore components with confidence = 0 #1907
Conversation
This comment has been minimized.
This comment has been minimized.
I suspect this might also fix a number of other bugs around rules too-greedily warning on non-components. Would you mind checking the open issues and seeing if there's additional test cases that could apply here? |
Oh yes, I remember at least seeing #1800 which seems to be the same issue that's being fixed here. Will check that and others. |
Added tests for the original issue in #1800, plus #1800 (comment) |
Resolves #1637
Resolves #1800